-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1614503 [wpt PR 21707] - [Import Maps] Make errors block the whol…
…e resolution, Blink-side, a=testonly Automatic update from web-platform-tests [Import Maps] Make errors block the whole resolution, Blink-side Reflects WICG/import-maps#205. This CL updates tests from #205. To match the behavior with the updated spec, this CL turns non-String values into `null` entries (i.e. make whole resolution fail without further fallback), instead of ignoring such entries. Other aspects were already conformant with the updated spec (i.e. weren't matching with the spec before #205). This CL updates (test-only) import maps serialization code so that it matches with the reference implementation, i.e. dump `null` entries as `null` instead of `[]`. This CL also updates spec comments. Bug: 990561, WICG/import-maps#184 Change-Id: Ifa2d04bf20fcef5575c14d135c328730ea09c454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037012 Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Reviewed-by: Kouhei Ueno <kouheichromium.org> Cr-Commit-Position: refs/heads/master{#740847} -- wpt-commits: 8767abfffb790e4928ac9433282928caa2357ee8 wpt-pr: 21707 UltraBlame original commit: e620b95565ea737f093567c22c6b8ce07e37b7dc
- Loading branch information
Showing
7 changed files
with
1,048 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,6 +168,15 @@ | |
. | ||
json | ||
' | ||
' | ||
resources | ||
/ | ||
resolving | ||
- | ||
null | ||
. | ||
json | ||
' | ||
] | ||
) | ||
{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -482,6 +482,16 @@ imports | |
: | ||
{ | ||
" | ||
unparseable2 | ||
" | ||
: | ||
null | ||
" | ||
unparseable3 | ||
" | ||
: | ||
null | ||
" | ||
invalidButParseable1 | ||
" | ||
: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,6 +61,12 @@ imports | |
" | ||
: | ||
{ | ||
" | ||
trailer | ||
/ | ||
" | ||
: | ||
null | ||
} | ||
" | ||
scopes | ||
|
Oops, something went wrong.