Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed problem on using parameters without secret #4

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

ochanje210
Copy link
Contributor

@ochanje210 ochanje210 commented Jan 17, 2017

Without secret, the request url missed ? and resulted 404 response when there are parameters.
Here, I have tried to fix it in simple way by adding ? to url directly.

Without secret, the request url missed `?` and resulted 404 response.
@marckrenn
Copy link
Owner

Thanks!

@marckrenn marckrenn merged commit 2fee6b8 into marckrenn:master Jan 18, 2017
@ochanje210
Copy link
Contributor Author

I should have tested enough for the previous PR. X(

@marckrenn
Copy link
Owner

No problem, I didn't notice it either as I rarely use parameters myself.

I think the last time I used it was to write a sequential loader to load large structures (containing base64-encoded images) on an one-by-one basis. Maybe I'll add it to the demo projects with the next update 👍

@marckrenn
Copy link
Owner

marckrenn commented Jan 19, 2017

Not so fast! :)
Just noticed that your PR breaks compatibility with firebase.secret, so I had to revert it. Seems like the request query is missing the question mark when using secret. Could you look into this problem by using one of my demo files (e.g. this one)? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants