test(bash): Add a bunch of tests for bash special characters.#25
test(bash): Add a bunch of tests for bash special characters.#25marckhouzam merged 2 commits intomarckhouzam:mainfrom
Conversation
JeffFaer
force-pushed
the
special_characters
branch
from
52254c1 to
dd845de
Compare
|
I’m trying to look into this one, but I’m having docker issues. Some update site is down right now. I’ll try again later on. |
marckhouzam
left a comment
marckhouzam
left a comment
There was a problem hiding this comment.
I've merged #24, so you can rebase this on the new main
Done! |
|
@JeffFaer Could you sign-ff the two last commits, or else the DCO check fails. |
JeffFaer
force-pushed
the
special_characters
branch
2 times, most recently
from
a6e57de to
2810560
Compare
|
I've pushed a new commit to this PR to help in testing: 14557ce |
|
@JeffFaer I'm almost ready to merge this but one of your commit does not have the "Signed-off-by" and fails the DCO check. Could you fix that and push it back please? |
|
@JeffFaer I have pushed a commit on top of yours which adds some tests for special-characters when using completion descriptions. I'm happy with this PR and will merge as soon as you can repush it to properly add the signed-off to your commit. |
Signed-off-by: Jeffrey Faer <jeffrey.faer@gmail.com>
JeffFaer
force-pushed
the
special_characters
branch
from
473bdc0 to
0cc3694
Compare
|
Done! |
Also, avoid changing COMP_TYPE. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
marckhouzam
force-pushed
the
special_characters
branch
from
307f691 to
432c3f6
Compare
| _completionTests_verifyCompletion "testprog prefix nospace b" "bear bearpaw" nospace | ||
| _completionTests_verifyCompletion "testprog prefix nofile b" "bear bearpaw" nofile | ||
| # COMP_TYPE does not get set by bash 3 | ||
| if [ $BASH_VERSINFO != 3 ]; then |
There was a problem hiding this comment.
It turns out that there is no point in running the tests that set COMP_TYPE for bash 3 because COMP_TYPE only gets set by bash 4. So the tests were passing because we were setting COMP_TYPE ourselves, but it is not representative of what bash 3 does. So I have disable then for bash 3.
marckhouzam
left a comment
marckhouzam
left a comment
There was a problem hiding this comment.
Well this was quite the learning experience.
Thanks @JeffFaer for your work.
I have added a commit on top of your to tweak a few things, and I feel we are in a good state with this set of new tests.
2 participants
Right now, these tests fail. They will pass after spf13/cobra#2126 has been merged.
This PR is based on top of #24