Add locale Japanese #106
Merged
Add locale Japanese #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchellodev
requested changes
Sep 4, 2021
lib/conf.dart
Outdated
| @@ -287,6 +293,12 @@ List<Language> get languageList => [ | |||
| nameLocal: 'italiano', | |||
| locale: const Locale('it'), | |||
| localizations: AppLocalizationsIt()), | |||
| Language( | |||
| // 85 million | |||
There was a problem hiding this comment.
Wikipedia states that about 128 million people speak Japanese.
Therefore, in the comment it should say 120 million, not 85 million. Also, this Language object should be moved up the array based on that, as we are sorting languages by the number of speakers.
lib/conf.dart
Outdated
| name: 'japanese', | ||
| nameLocal: '日本語', | ||
| locale: const Locale('ja'), | ||
| localizations: AppLocalizationsIt()), |
There was a problem hiding this comment.
AppLocalizationsIt()=> AppLocalizationsJa()
added 2 commits
September 4, 2021 19:54
|
Thank you! |
|
Analytics is disabled when the app runs in the debug mode, so there was no need to do that :) Thanks, I'll merge this now! |
|
@312k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Japanese!
Closes #105