This repository has been archived by the owner on Jan 9, 2019. It is now read-only.
Add the ability to specify the input encoding for the LessCompiler. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efaults to the default encoding if not specified.
|
Hi! Can you do me a favour? Can you redo it from the latest master as i would need to merge. thanks |
|
Sure. I'll give it a shot. |
|
This change breaks the API. Could you keep the get/setEncoding method and maybe have it set both input and output encoding at the same time? You can keep your setInputEncoding and setOutputEncoding as well, just don't get rid of get/setEncoding. |
|
@bbrouwer That makes sense. I'll keep that in mind when reimplementing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to the default encoding if not specified. This is useful when using LESS files that contain non-ASCII content such as those provided by font libraries such as Fontello, on a system whose default encoding is not UTF-8.