Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some new actions and corresponding events about ConfBridge #179

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add some new actions and corresponding events about ConfBridge #179

wants to merge 5 commits into from

Conversation

brenard
Copy link

@brenard brenard commented Jan 25, 2019

Hi,

I implement some new actions and corresponding events about ConfBridge :

  • ConfbridgeListRooms action and it's ConfbridgeListRooms and ConfbridgeListRoomsComplete events
  • ConfbridgeLock and ConfbridgeUnlock actions (no corresponding event)
  • ConfbridgeKick action (no corresponding event)
  • ConfbridgeStartRecord and ConfbridgeStopRecord actions (no corresponding event)

This PR include tests as implemented for other similar actions/events.

Thank you,

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.036% when pulling d35fbb7 on brenard:master into f586d0f on marcelog:master.

@coveralls
Copy link

coveralls commented Jan 25, 2019 •
edited
Loading

Coverage Status

Coverage increased (+6.1%) to 98.357% when pulling 64b72d3 on brenard:master into f586d0f on marcelog:master.

@beqabeqa473
Copy link

hi, why you are not merging this pr to the master?

i think lots of people need this functionality which is absent in original repo.

dkgroot added a commit to chan-sccp/PAMI that referenced this pull request Apr 24, 2019
@dkgroot
Merge commit 'refs/pull/179/merge' of github.com:marcelog/PAMI into PR5
30e41ac 
PR: marcelog#179
PR Description: Add some new actions and corresponding events about ConfBridge
Provided by: @brenard

Fixed minor merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brenard @coveralls @beqabeqa473