Fixed #57: Incorrect EOF test in getMessages #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkgroot
pushed a commit
to chan-sccp/PAMI
that referenced
this pull request
Apr 24, 2019
Cherry-Picked 6cbc707 from thomasvargiu (marcelog#122) references marcelog#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to send a Logoff action. When this happens, Asterisk sends a response message and then close the connection. With this PR is possible to read the Logoff response message without throwing an exception if it's the last message and the connection is closed after that.
Also related to #121, because it's a good practice to send a logoff to disconnect, but sending it could throws an exception at this moment. This PR fix this.
Some little fixes on the code found debugging it.