Set error on a span with an unhandled :erlang.exit() #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for a great OTel decorator!
The decorator handles Elixir exceptions and errors well, but in the most general case it's possible that we might call some code (possibly in Erlang) that will just
:erlang.exit/1,2
. In such a case, with the current code, a span is not marked as an error and contains almost no tags, which makes it hard to pinpoint the problem:With this PR such a span is correctly marked as an error with
otel.status_description
being set to the Erlang exception class (one ofthrow
,error
, orexit
) and a reason: