Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using nvim for processing helptags and more #34

Merged
merged 1 commit into from
May 18, 2019

Conversation

comfortablynick
Copy link
Contributor

Neovim-only compatibility

I only have Neovim installed on my system, and I was getting a panic with "something went wrong" as the message after plugin installs. This PR allows nvim to be called at the end of the install process if vim returns NotFound. With this change, things seem to work fine (so far) with Neovim.

Fix clippy warnings

  • Replace deprecated env::home_dir() with equivalent from dirs crate
  • Use character instead of single character string
  • Use iter() instead of into_iter() in one place

There are clippy warnings about redundant closures, but that may be a bug.

Add dirs crate to replace deprecated env function
@maralla
Copy link
Owner

maralla commented May 18, 2019

Thanks!

@maralla maralla merged commit 7ef7465 into maralla:master May 18, 2019
comfortablynick added a commit to comfortablynick/pack that referenced this pull request May 18, 2019
Merge pull request maralla#34 from comfortablynick/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants