Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to fix the locale issue in the Pehla School Library #292

Merged
merged 11 commits into from
Aug 21, 2019

Conversation

bikashtudu
Copy link

PR checklist Status
Is issue created in GitHub? Yes
Are the changes replicated across different locales? No
Is code analysis task executed and issues resolved in the Java/Kotlin code? NA
Is code analysis task executed and issues resolved in the CPP/native code? NA
Is the version code set in the AndroidManifest.xml or build.gradle file to 1 more than the version which has already been published? NA
Is code commenting done properly for the changes made? NA
Is correct variable naming convention followed? NA
Is auto formatting shortcut Ctrl+Alt+Shift+L executed in all files? NA
Are the message strings used in the application taken from strings.xml file? NA
Are the permissions which are not required removed from AndroidManifest.java file? NA
Is the uses-feature tag used for only must have feature in AndroidManifest.java file? NA
Are the generated files correctly configured in .gitignore? NA
Are the release signing configurations removed from the gradle files? NA
Is commented code removed from all files? NA
Are updated images compressed (< 100 KB)? NA
Ensured there are no typos in any string. For example: Variable/method names, hardcoded strings, commit messages, PR titles, issues, code comments? Yes

@bikashtudu bikashtudu requested review from Shailin and ankitk20 August 13, 2019 13:10
@bikashtudu bikashtudu self-assigned this Aug 13, 2019
@bikashtudu bikashtudu added the bug Something isn't working label Aug 13, 2019
@Shailin Shailin self-requested a review August 20, 2019 10:21
@ankitk20 ankitk20 merged commit b7b6dba into newmaster Aug 21, 2019
@bikashtudu bikashtudu deleted the BikashT/LibraryBackFix branch August 23, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants