Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Title Position in PlaceValue Game #241

Open
wants to merge 1 commit into
base: newmaster
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2019

PR checklist Status
Is issue created in GitHub? Yes
Are the changes replicated across different locales? No
Is code analysis task executed and issues resolved in the Java/Kotlin code? NA
Is code analysis task executed and issues resolved in the CPP/native code? Yes
Is the version code set in the AndroidManifest.xml or build.gradle file to 1 more than the version which has already been published? NA
Is code commenting done properly for the changes made? Yes
Is correct variable naming convention followed? NA
Is auto formatting shortcut Ctrl+Alt+Shift+L executed in all files? Yes
Are the message strings used in the application taken from strings.xml file? NA
Are the permissions which are not required removed from AndroidManifest.java file? NA
Is the uses-feature tag used for only must have feature in AndroidManifest.java file? NA
Are the generated files correctly configured in .gitignore? NA
Are the release signing configurations removed from the gradle files? NA
Is commented code removed from all files? NA
Are updated images compressed (< 100 KB)? NA
Ensured there are no typos in any string. For example: Variable/method names, hardcoded strings, commit messages, PR titles, issues, code comments? Yes

@ghost ghost added the minor fix Min label Jul 26, 2019
@ghost ghost requested review from mathewnik90 and ankitk20 July 26, 2019 05:31
@ghost ghost self-assigned this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants