Fix TTS playback issue #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikashtudu
commented
Jul 25, 2019
•
bikashtudu
commented
| PR checklist | Status |
|---|---|
| Is issue created in GitHub? | Yes |
| Are the changes replicated across different locales? | No |
| Is code analysis task executed and issues resolved in the Java/Kotlin code? | NA |
| Is code analysis task executed and issues resolved in the CPP/native code? | Yes |
| Is the version code set in the AndroidManifest.xml or build.gradle file to 1 more than the version which has already been published? | NA |
| Is code commenting done properly for the changes made? | Yes |
| Is correct variable naming convention followed? | NA |
| Is auto formatting shortcut Ctrl+Alt+Shift+L executed in all files? | Yes |
| Are the message strings used in the application taken from strings.xml file? | NA |
| Are the permissions which are not required removed from AndroidManifest.java file? | NA |
| Is the uses-feature tag used for only must have feature in AndroidManifest.java file? | NA |
| Are the generated files correctly configured in .gitignore? | NA |
| Are the release signing configurations removed from the gradle files? | NA |
| Is commented code removed from all files? | NA |
| Are updated images compressed (< 100 KB)? | NA |
| Ensured there are no typos in any string. For example: Variable/method names, hardcoded strings, commit messages, PR titles, issues, code comments? | Yes |
# Conflicts: # pehlaschool/Classes/Common/Controls/CompletePopup.cpp # pehlaschool/Classes/Games/Books/BookPage.cpp # pehlaschool/Classes/Games/ComprehensionTest/ComprehensionScene.cpp # pehlaschool/Classes/Games/DigitalQuiz/Utils/DigitalQuizMainDepot.cpp # pehlaschool/Classes/Games/EggQuiz/EggQuizHeader.hpp # pehlaschool/Classes/Games/EggQuiz/EggQuizScene.cpp # pehlaschool/Classes/Games/FindTheMatch/ChildNodes/FindTheMatchCard.cpp # pehlaschool/Classes/Games/LRComprehension/LRComprehensionScene.cpp # pehlaschool/Classes/Games/MovingInsects/ChildNodes/MovingInsectsGameBoard.cpp # pehlaschool/Classes/Games/MultiplicationBoard/MultiplicationBoardScene.cpp # pehlaschool/Classes/Games/NumberTrain/TrainCar.cpp # pehlaschool/Classes/Games/PlaceValue/PlaceValueScene.cpp # pehlaschool/Classes/Games/ReadingBird/ReadingBirdScene.cpp # pehlaschool/Classes/Games/StarFall/Core/StarFallScene.cpp # pehlaschool/Classes/Games/WhatIsThis/WhatIsThisCard.cpp # pehlaschool/Classes/Games/WordMachine/WordMachineScene.cpp # pehlaschool/Classes/Games/WordTrace/Utils/WordTraceMainDepot.cpp # pehlaschool/Classes/Games/WordWindow/WordWindowScene.cpp # pehlaschool/Classes/Managers/LanguageManager.cpp # pehlaschool/Classes/Menu/CoopScene.cpp # pehlaschool/Classes/Menu/CoopScene2.cpp # pehlaschool/Classes/Menu/DailyScene2.cpp # pehlaschool/Classes/Menu/GradeSelector.cpp # pehlaschool/Classes/Utils/TodoUtil.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.