Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the volume to 50% when the app starts #26

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Conversation

RickyRiko305
Copy link
Contributor

@RickyRiko305 RickyRiko305 commented Jul 6, 2019

PR checklist Status
Is issue created in GitHub? Yes
Is code analysis task executed and issues resolved in the Java/Kotlin code? Yes
Is code analysis task executed and issues resolved in the CPP/native code? NA
Is the version code set in the AndroidManifest.xml or build.gradle file to 1 more than the version which has already been published? NA
Is code commenting done properly for the changes made? Yes
Is correct variable naming convention followed? Yes
Is auto formatting shortcut Ctrl+Alt+Shift+L executed in all files? Yes
Are the message strings used in the application taken from strings.xml file? NA
Are the permissions which are not required removed from AndroidManifest.java file? NA
Is the uses-feature tag used for only must have feature in AndroidManifest.java file? NA
Are the generated files correctly configured in .gitignore? NA
Are the release signing configurations removed from the gradle files? NA
Is commented code removed from all files? NA
Are updated images compressed (< 100 KB)? NA
Ensured there are no typos in any string. For example: Variable/method names, hardcoded strings, commit messages, PR titles, issues, code comments? Yes

@RickyRiko305 RickyRiko305 added the enhancement New feature or request label Jul 6, 2019
@RickyRiko305 RickyRiko305 self-assigned this Jul 6, 2019
@mathewnik90 mathewnik90 merged commit a7e378c into master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants