Fix broken light (invalid use of heavy dependencies) #1449
Conversation
- move elevation calculation to serve_rendered and stub in serve_light due to use of canvas and sharp - elevation api is not available for light
|
Do you know if the is a isLight flag in the template? it might be goot to not show the elevation display on the terrain page.. |
|
I am fine with moving this to serve_rendered.js for now. though I have been thinking about ways to shorten that file since it is quite large (like separating it out into other files a bit) maybe we could make a terrain.js file and for now have it access through rendering so we don't need a new dummy file.. idk. this could be a first step though to at least get light working. |
|
Yes, in general it not the best solution, but may be I had chosen this before, too, just to not have multiple locations with different code. And in fact because we use images here, it is a kind of rendering, too. I tested light and normal again, looks fine now and finaly: I removed the control in light mode, too :) |
|
can you also hide this elevation url? since that is unavalable in light
|
|
Done. I added a note to the docs, too. |
|
Does preview terrain get hidden when that link is gone? It seemed like that part still worked ok but now it doesn't show
|
|
Yes, now the links are handled in dedicated flags. |
serve_renderedand stub inserve_lightdue to use ofcanvasandsharpPossible fix for #1448