Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak warning in the Achievement Badge Test #2511

Merged
merged 3 commits into from
Dec 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions src/components/AchievementBadge/AchievementBadge.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -321,19 +321,44 @@
},
})

export const AchievementBadge = props => {
const AchievementBadge = props => {
const [badgeInfo, setBadgeInfo] = useState(null)
const [badgeImage, setBadgeImage] = useState(null)
const { achievement, size } = props

useEffect(() => {
let isMounted = true

const merged = _merge({}, badgeSettings[achievement], badgeSettings[achievement][size])
setBadgeInfo(merged)
if (isMounted) {
setBadgeInfo(merged)
}

return () => {
isMounted = false
}
}, [achievement, size])

useEffect(() => {
if (badgeInfo) {
badgeInfo.image().then(module => setBadgeImage(module.default))
let isMounted = true

const loadImage = async () => {
if (badgeInfo) {
try {
const image = await badgeInfo.image()
if (isMounted) {
setBadgeImage(image.default)
}

Check warning on line 351 in src/components/AchievementBadge/AchievementBadge.jsx

View check run for this annotation

Codecov / codecov/patch

src/components/AchievementBadge/AchievementBadge.jsx#L350-L351

Added lines #L350 - L351 were not covered by tests
} catch (error) {
console.error("Error loading badge image", error)
}

Check warning on line 354 in src/components/AchievementBadge/AchievementBadge.jsx

View check run for this annotation

Codecov / codecov/patch

src/components/AchievementBadge/AchievementBadge.jsx#L353-L354

Added lines #L353 - L354 were not covered by tests
}
}

loadImage()

return () => {
isMounted = false
}
}, [badgeInfo])

Expand Down
Loading