add endpoint for fetching task markers specifically #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I'll get this rebased |
CollinBeczak
force-pushed
the
connect-to-new-endpoint-for-fetching-specifically-task-markers
branch
from
60fa2d2 to
5e23f89
Compare
|
CollinBeczak
force-pushed
the
connect-to-new-endpoint-for-fetching-specifically-task-markers
branch
from
5e23f89 to
a48ab8e
Compare
jake-low
reviewed
Dec 10, 2024
jake-low
reviewed
Dec 10, 2024
jake-low
reviewed
Dec 10, 2024
There was a problem hiding this comment.
LGTM other than the noted docs typos, but I think you should wait for @ljdelight's signoff too before merging as he's more familiar with the backend code than I am.
|
|
(Approved in direct conversation) |
CollinBeczak
deleted the
connect-to-new-endpoint-for-fetching-specifically-task-markers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PUT /tasks/box/:left/:bottom/:right/:topendpoint has some unneeded complexity when fetching for task markers. The reason why that endpoint was so complex is because it is also used to fetch task table data. This led to slower performance when fetching markers because paging, ordering, and sorting was applied.Because that structure is needed for the tables but not for fetching tasks markers, I have created a new endpoint to reduce complexity:
PUT /tasks/markers/:left/:bottom/:right/:top.This new endpoint exports the same task data as the previous endpoint, but doesn't query for the total task count, and also doesn't do any ordering or paging.
21771 task in view with 1001 task limit:
Old endpoint (Time to complete: ~ 1.1s-1.9s ):
New endpoint (Time to complete: ~ 400ms-600ms):
977 task in view with 1001 task limit:
Old endpoint (Time to complete: ~ 450ms-700ms):
New endpoint (Time to complete: ~300ms-550ms):
Times were recorded on the same device at a similar time, and ran multiple times to get an average. There is a small performance increase with the new endpoint when the number of tasks in view is below the limit. A bigger performance increase is noticeable whenever there are significantly more than 1001 tasks(or the limit) as the endpoint no longer needs to query for all the tasks the meet the filter requirements to get the total tssk count.