Skip to content

Conversation

@matentzn
Copy link
Collaborator

@matentzn matentzn commented Oct 6, 2025

Workflow now triggers on published and prereleased events, sets PEP 440-compliant version for prereleases, and adds 'skip-existing' to PyPI publish step. Improves handling of pre-release publishing and artifact management.

Resolves #490

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

Workflow now triggers on published and prereleased events, sets PEP 440-compliant version for prereleases, and adds 'skip-existing' to PyPI publish step. Improves handling of pre-release publishing and artifact management.
@matentzn matentzn requested a review from Copilot October 6, 2025 19:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the PyPI publish workflow to properly handle pre-releases by triggering on both published and prereleased events, implementing PEP 440-compliant versioning for development snapshots, and adding skip-existing functionality for artifact publishing.

  • Expands workflow trigger from only published releases to include prereleases
  • Implements automatic PEP 440-compliant versioning for prereleases using date, run number, and git SHA
  • Adds skip-existing option to prevent PyPI publish failures on duplicate uploads

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pypi-publish.yaml Updates workflow triggers, adds prerelease versioning logic, and improves PyPI publish configuration
CHANGELOG.md Documents the new pre-release functionality for development snapshots

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@matentzn matentzn requested a review from Copilot October 6, 2025 19:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@matentzn matentzn requested a review from gouttegd October 6, 2025 19:46
Eliminates the step that sets a PEP 440-compliant pre-release version in the PyPI publish workflow. This simplifies the workflow and relies on the tags provided by the github release.
Renamed the build step in the PyPI publish workflow for clarity, changing 'Build sdist & wheel' to 'Build source and wheel archives'.
Removed an unnecessary blank line and reset the comment for the id-token permission in the PyPI publish GitHub Actions workflow.
@matentzn matentzn requested a review from gouttegd October 6, 2025 20:51
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

You might want to add some notes somewhere that it is the responsibility of whoever wants to do a ”pre-release” to remember to create the release tag accordingly (i.e. a release tag that includes a aN, bN, .devN suffix, depending on the desired type of pre-release).

@matentzn matentzn merged commit 62d8249 into master Oct 6, 2025
3 checks passed
@matentzn matentzn deleted the add-pypi-prerelease branch October 6, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make “development releases“ of sssom

3 participants