Clarify the absence of link between author_id and author_label. #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is not supposed to be any link between `author_id` and `author_label`. In particular, `author_label[n]` is _not_ intended to be the human-friendly label of `author_id[n]`. This has seemingly always been the intention (see notably this comment: #344 (comment)) but has never been made explicit in the schema, which is what we do here. Likewise for reviewer_id/reviewer_label and creator_id/creator_label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#344]
[ ]not needed, doc is in the modeldocs/have been added/updated if necessarymake testhas been run locally[ ] tests have been added/updated (if applicable)nothing to test[ ] CHANGELOG.md has been updated.not needed, this is a clarification onlyThere is not supposed to be any link between
author_idandauthor_label. In particular,author_label[n]is not intended to be the human-friendly label ofauthor_id[n].This has seemingly always been the intention (see notably this comment: #344 (comment)) but has never been made explicit in the schema, which is what this PR is about.
Likewise for
reviewer_id/reviewer_labelandcreator_id/creator_label.