Skip to content

Conversation

@matentzn
Copy link
Collaborator

Clarifying the intended use of subject and object match field in the main slot descriptions.

Fixes #413

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model
  • run SSSOM-Py test suite against the updated model

Make it a bit clearer how subject and object_match_field are supposed to be used.

@nichtich does this work for you?

Clarifying the intended use of subject and object match field in the main slot descriptions.
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks, but otherwise LGTM.

@matentzn matentzn requested a review from gouttegd March 27, 2025 15:58
gouttegd
gouttegd previously approved these changes Mar 27, 2025
@matentzn matentzn requested review from ehartley and graybeal March 28, 2025 08:39
@matentzn
Copy link
Collaborator Author

@ehartley thank you for the suggestions; @gouttegd sorry for having to ask for another approval, this is mandated after changes to a PR.

@matentzn matentzn merged commit 87ba869 into master Mar 29, 2025
3 checks passed
@matentzn matentzn deleted the issue413-docsubjectmatchstring branch March 29, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how mapping_justification implies other fields and vice versa

4 participants