Minor fix to the “overview” document regarding the TSV format #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the bit in the specification that suggested the `curie_map` parameter in the YAML metadata of a mapping set could be a link to an external curie map. `curie_map` should only be used to provide an embedded curie map. It is unclear whether an external curie map should be allowed at all, but if it is, it should be specified using a distinct parameter.
The recommendation is that the external metadata file, when present, should have the extension `.sssom.yml` (not `-meta.yml`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses [#283]
docs/have been added/updated if necessarymake testhas been run locally (N/A; documentation change only)This PR fixes point 1. and 2. described in #283 (disallowing the use of
curie_mapas a link to an external curie map and fixing a discrepancy in the recommended file naming convention for the external metadata file).