Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSSOM Extended Prefix Map #568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request updates sssom extended prefix map (epm). Make sure you run make tests manually.

@@ -5282,6 +5296,7 @@
"prefix_synonyms": [
"MEDLINE",
"PubMed",
"PubMed ID",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cthoyt whitespace in a prefix, even if synonym?

@@ -5290,6 +5305,7 @@
"http://bio2rdf.org/pubmed:",
"http://bioregistry.io/MEDLINE:",
"http://bioregistry.io/PMID:",
"http://bioregistry.io/PubMed ID:",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks bad.. @cthoyt

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fearing the pubmed ID with whitespace might cause issues, wanting @cthoyt feedback before proceeding

@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from 8a140ac to 20d99f6 Compare December 30, 2024 12:22
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 20d99f6 to f3e409f Compare January 13, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant