Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

September cleaning 1 #413

Merged
merged 9 commits into from
Sep 11, 2023
Merged

September cleaning 1 #413

merged 9 commits into from
Sep 11, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Sep 9, 2023

This PR does several bits of refactoring, but does not change any functionality. These include:

  1. Better registry pattern for writers and readers
  2. Remove deprecated functions long marked for deletion
  3. Remove commented out imports and dead code in some places
  4. Remove prints from tests, turn down logging levels when unnecessary
  5. Refactoring for unnecessarily complex functions - mostly inverting the order of conditionals to avoid deep nesting, to combine multiple independent loops with itt.product
  6. Refactoring to remove unnecessary back and forth conversion between lists and sets
  7. Refactoring to improve variable names

1. Better registry pattern for writers and readers
2. Remove deprecated functions long marked for deletion
3. Remove commented out imports and dead code in some places
4. Minor refactoring in CLI
@cthoyt cthoyt requested a review from hrshdhgd September 10, 2023 09:26
Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome refactor and dead-code removal @cthoyt ! Thanks a ton!

@hrshdhgd hrshdhgd merged commit 1fc45ec into master Sep 11, 2023
@hrshdhgd hrshdhgd deleted the sept-cleaning-1 branch September 11, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants