Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to find latest applicable mapnik version #108

Closed
flippmoke opened this issue Sep 10, 2015 · 4 comments
Closed

Add ability to find latest applicable mapnik version #108

flippmoke opened this issue Sep 10, 2015 · 4 comments
Assignees
@yohanboniface

Comments

@flippmoke
Copy link
Member

Currently it is required that every single version of Mapnik have its own folder in mapnik reference, however, with the quicker iteration of mapnik releases there may not always be any changes to mapnik-reference required. Therefore mapnik-reference should attempt to auto detect a version if the folder does not exist.

The auto finding of another version of mapnik should only find the latest patch version that is lower then or equal to the version of mapnik.

Therefore:

If our versions in mapnik-reference are:

  • 3.0.0
  • 3.0.3

3.0.1 would use 3.0.0
3.0.3 would use 3.0.3
3.0.4 would use 3.0.3
3.1.0 would fail because there is not a 3.1.0

/cc @yohanboniface
@yohanboniface
Copy link
Member

One question: are we sure we want to have versions for patches? A patch means that the API has not changed, and thus, given that the mapnik-reference describes the API, I'm not sure it makes sense to have versions for Mapnik patches here. Thoughts?

@flippmoke
Copy link
Member Author

@yohanboniface It is possible that a patch release could introduce new features but not disrupt any existing API features, so yes. 3.0.3 is an example of this.

@yohanboniface
Copy link
Member

Okay. It feel we could find a simpler workflow, but let's go this way for now. :)
@flippmoke can you set gh-pages as default branch? cf #107

@yohanboniface yohanboniface self-assigned this Sep 14, 2015
yohanboniface added a commit that referenced this issue Sep 14, 2015
@yohanboniface
Use semver to define which version to load (fix #108)
4d7ee30 
This also:

- dynamically builds the available versions by listing
  the versions directories.
- introduces module.latest, that point to the latest version
  id available

Using "semver" module, this will also allow much advanced loading
syntax (like ranges, carret, star or x…).
@yohanboniface yohanboniface mentioned this issue Sep 14, 2015
Closed
yohanboniface added a commit that referenced this issue Sep 14, 2015
@yohanboniface
Use semver to define which version to load (fix #108)
69e02a6 
This also:

- dynamically builds the available versions by listing
  the versions directories.
- introduces module.latest, that point to the latest version
  id available

Using "semver" module, this will also allow much advanced loading
syntax (like ranges, carret, star or x…).
springmeyer pushed a commit that referenced this issue Mar 5, 2016
support for dynamically loading latest ref - refs #109 #108
08437ab
@springmeyer
Copy link
Member

landed in 08437ab

springmeyer pushed a commit that referenced this issue Mar 5, 2016
get rid of refs that represent mapnik version without any changes - r…
509c1a5 
…efs #108
springmeyer pushed a commit that referenced this issue Mar 5, 2016
get rid of more refs that represent mapnik versions without any chang…
8976907 
…es - refs #108
springmeyer pushed a commit that referenced this issue Mar 5, 2016
trim back versions after #108
b0d4d48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yohanboniface yohanboniface

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@springmeyer @yohanboniface @flippmoke