-
-
Notifications
You must be signed in to change notification settings - Fork 351
fix: logs not being integrated with the path-prefix correctly
#2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CommanderStorm
merged 21 commits into
maplibre:main
from
CommanderStorm:prefix-aware-logs
Feb 11, 2026
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b66add5
fix logs not having the prefixes correct
CommanderStorm aa03173
Update martin/src/bin/martin.rs
CommanderStorm 03887dc
Update martin/src/bin/martin.rs
CommanderStorm e1ce638
chore(fmt): apply pre-commit formatting fixes
pre-commit-ci[bot] 097874b
Apply suggestions from code review
CommanderStorm ed4fbad
Apply suggestion from @CommanderStorm
CommanderStorm 3a26869
Apply suggestions from code review
CommanderStorm 406b34e
Apply suggestion from @CommanderStorm
CommanderStorm 80c2a95
Apply suggestion from @CommanderStorm
CommanderStorm 5a972f8
Apply suggestion from @CommanderStorm
CommanderStorm e5229c1
chore(fmt): apply pre-commit formatting fixes
pre-commit-ci[bot] b0bd2d5
Merge branch 'main' into prefix-aware-logs
CommanderStorm ab96a31
minor text improvements
nyurik a289c6e
chore(fmt): apply pre-commit formatting fixes
pre-commit-ci[bot] e06cf46
Apply suggestions from code review
CommanderStorm a011ef3
Apply suggestion from @CommanderStorm
CommanderStorm 644dbdb
chore(fmt): apply pre-commit formatting fixes
pre-commit-ci[bot] 79098f0
Apply suggestion from @CommanderStorm
CommanderStorm 7ef16a8
Apply suggestion from @CommanderStorm
CommanderStorm 1e1fedc
chore(fmt): apply pre-commit formatting fixes
pre-commit-ci[bot] f277205
Apply suggestion from @CommanderStorm
CommanderStorm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we use both
info!andtracing::info!in the same file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this here is guarded by the cfg, the other is imported actually.
Since we have the no-unused imports, it is either this or ugly/hard to maintain cfg imports at the top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to even add a comment about that - as i think i caught this one before too :)