Merged
Conversation
nyurik
reviewed
May 29, 2025
for more information, see https://pre-commit.ci
Member
CommanderStorm
left a comment
CommanderStorm
left a comment
There was a problem hiding this comment.
Nice work.
I have left a few comments below, nothing major
for more information, see https://pre-commit.ci
Collaborator
Author
|
Thx! @nyurik @CommanderStorm will be back hours later :) |
sharkAndshark
commented
Jun 7, 2025
nyurik
reviewed
Jun 7, 2025
Collaborator
Author
|
Something could be added in next:
|
nyurik
approved these changes
Jun 10, 2025
Member
nyurik
left a comment
nyurik
left a comment
There was a problem hiding this comment.
@sharkAndshark looks good to me. I made a number of minor changes, and moved the docs to a dedicated readme (included with the module). Please take a look at a few FIXME i left there - you may want to fix them before we merge, but feel free to merge whenever you feel its ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the 4th PR of #1814 to fix #1820
Imageand many func moved fromSource.rstoimage.rsMetagot removed and its fields moved toSourcergb_to_pngto three:rgb_to_pngensure_pixels_validandencode_rgba_to_pngBefore we add more fields and helper methods, a refactor is needed.