improve fmt and related just commands#1854
Merged
nyurik merged 1 commit intomaplibre:mainfrom May 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Consolidates and simplifies formatting targets, removes unused config, and applies consistent reformatting across the codebase.
- Deletes obsolete
rustfmt.toml - Merges nightly and stable
cargo fmtinto onejust fmtrecipe (with fallback) - Reorders and combines imports in modules for a consistent style
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rustfmt.toml | Removed unused rustfmt configuration |
| martin/src/styles/mod.rs | Reordered use statements |
| martin/src/srv/styles.rs | Consolidated Actix imports and moved StyleSources import |
| martin/src/sprites/mod.rs | Combined collection imports |
| martin/src/source.rs | Moved HashMap import to file top |
| martin/src/pmtiles/mod.rs | Split AWS S3 imports onto separate lines |
| martin/src/fonts/mod.rs | Removed duplicated HashMap import |
| martin/src/cog/source.rs | Reordered test use statements |
| martin/src/cog/model.rs | Split tiff imports |
| martin/src/args/root.rs | Simplified clap imports |
| justfile | Updated formatting/checking recipes (fmt, test-fmt), removed --unsorted from default |
Comments suppressed due to low confidence (1)
martin/src/pmtiles/mod.rs:13
- [nitpick] For brevity and consistency, you could combine these two imports into
use pmtiles::aws_sdk_s3::{Client as S3Client, config::Builder as S3ConfigBuilder};.
use pmtiles::aws_sdk_s3::Client as S3Client;
* consolidated `just fmt` will format using nightly (preferred) or regular `cargo fmt`. This is identical to what we had before as `just fmt2` * remove unused rustfmt.toml * reformatted everything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just fmtwill format using nightly (preferred) or regularcargo fmt. This is identical to what we had before asjust fmt2