feat: add Mbtiles::contains#1850
Merged
CommanderStorm merged 10 commits intomaplibre:mainfrom May 25, 2025
Merged
Conversation
Contributor
|
This looks great! I wanted to send another PR for this tomorrow, but you beat me to it. And you did a better job with doc comments, I really like them 👍🏻 |
nyurik
reviewed
May 25, 2025
CommanderStorm
added a commit
that referenced
this pull request
May 25, 2025
these tests are getting overwhealming. this PR splits out the metadata tests into their own testcases to make hiding them simpler Merging this is part of #1850 and does help with making it reviewable --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
CommanderStorm
commented
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a bit of the pool testcase changes are a bit off-topic from the other changes there.
Have moved them to another PR => Should be reviewed after
Otherwise should be rather self-explainatory.
CC @Murtaught does this improve the usecase you mentioned in #1841 ?