Conversation
nyurik
requested review from
CommanderStorm and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Clippy 1.87 warnings by updating logging and output formatting for file paths to use the proper display methods.
- Updated warning messages in martin/src/styles/mod.rs to use path.display()
- Updated error logging in martin/src/srv/styles.rs to use path.display()
- Updated build output logging in martin/build.rs to use path.display()
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| martin/src/styles/mod.rs | Improved logging with proper path display formatting |
| martin/src/srv/styles.rs | Fixed error logging formatting for consistency |
| martin/build.rs | Updated build message for better path formatting |
for more information, see https://pre-commit.ci
louwers
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also increase timeout to 3s for markdown link checks