feat(docker): add labels, pin alpine tag to the latest version#1832
Merged
CommanderStorm merged 5 commits intomaplibre:mainfrom May 18, 2025
Merged
feat(docker): add labels, pin alpine tag to the latest version#1832CommanderStorm merged 5 commits intomaplibre:mainfrom
CommanderStorm merged 5 commits intomaplibre:mainfrom
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces two minimal improvements to the Dockerfile by standardizing OCI labels and pinning the base image tag.
- Updates the FROM instruction to use alpine:latest.
- Adds standardized labels for image source and licenses.
| @@ -1,7 +1,11 @@ | |||
| FROM alpine | |||
| FROM alpine:3.21 | |||
Member
There was a problem hiding this comment.
we have automatic dependency updates on
=> we get notified if something here is breaking => pinning to minor is imo fine for this one ^^
CommanderStorm
approved these changes
May 17, 2025
Member
CommanderStorm
left a comment
There was a problem hiding this comment.
Thanks for the improvements
Member
|
Actually, I am not sure if we use these labels or completely ignore them: martin/.github/workflows/ci.yml Lines 233 to 247 in c833034 Will have to investigate |
Member
|
(simplest way to investigate is merging and looking at the |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a few minimal
Dockerfileimprovements.Adds the following standardized
DockerfileLabels:I've noticed that some dependency upgrade tools (
renovate,dependabot, ...) can't fetch the martin changelog when creating Bump MRs.org.opencontainers.image.sourceshould alleviate that..Providing the licenses also doesn't hurt.
Furthermore I've pinned the tag to
latest, which makes it a bit cleaner. (same behavior as not pinning the tag at all).Pinning to a fixed version would be better - but without some sort of automation, keeping the tag up-to-date can be a hassle.
Seems like there are no problems regarding CI image caching however, as
martinis already using the newest alpine version:docker run --entrypoint /bin/sh ghcr.io/maplibre/martin:v0.16.0 -c "cat /etc/os-release""