feat: remove wastefull Dashmap from the catalog#1825
Merged
CommanderStorm merged 3 commits intomaplibre:mainfrom May 12, 2025
Merged
feat: remove wastefull Dashmap from the catalog#1825CommanderStorm merged 3 commits intomaplibre:mainfrom
Dashmap from the catalog#1825CommanderStorm merged 3 commits intomaplibre:mainfrom
Conversation
Merged
CommanderStorm
added a commit
that referenced
this pull request
May 12, 2025
I think we need an apt update to fix the CI failour in #1825
NINNiT
pushed a commit
to NINNiT/martin
that referenced
this pull request
May 17, 2025
I think we need an apt update to fix the CI failour in maplibre#1825
NINNiT
pushed a commit
to NINNiT/martin
that referenced
this pull request
May 17, 2025
Change the wastefull dashmap::Dashmap from the catalog to `std::collections::HashMap`. We are only using it to return values, so concurency here is just waste. Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the wastefull dashmap::Dashmap from the catalog to
std::collections::HashMap.We are only using it to return values, so concurency here is just waste.