hack: remove the PR file changed checks for CI#1806
Merged
CommanderStorm merged 2 commits intomaplibre:mainfrom Apr 25, 2025
Merged
hack: remove the PR file changed checks for CI#1806CommanderStorm merged 2 commits intomaplibre:mainfrom
CommanderStorm merged 2 commits intomaplibre:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to bypass the current CI failure issue on documentation-only pull requests by removing the file change checks that ignore markdown and docs file changes.
- Removed "paths-ignore" configuration from the pull_request trigger in the CI workflow file.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:7
- Removing the 'paths-ignore' block will cause CI to run on every docs PR, which might lead to unnecessary builds and increased CI load. Consider implementing a conditional job that only runs additional checks for non-doc changes.
- paths-ignore:
nyurik
approved these changes
Apr 25, 2025
Member
nyurik
left a comment
nyurik
left a comment
There was a problem hiding this comment.
sigh, i guess optimizations are just not worth the trouble of force override... i have seen some workflows that somehow iterate over all workflows and check if any failed... TBD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, a bit hacky and not the proper solution, but gets this bug silenced.
I don't like that CI always fails on docs PRs.
F.ex #1801 could be merged, but needs admin approval.
A proper solution would be to skip all except
CI FInishedif just docs were changed.