fix(ci): cargo update to evict the cache#1798
Merged
CommanderStorm merged 1 commit intomaplibre:mainfrom Apr 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps dependencies to bust the cache and updates the build script to use a compile‐time check for the RUSTDOC environment variable instead of the runtime approach.
- Removed the outdated cargo directive that triggered re-run of the build script via an environment variable.
- Replaced runtime environment variable check with a compile-time option_env! call.
Comments suppressed due to low confidence (1)
martin/build.rs:104
- The removal of the cargo directive that triggers the build re-run when RUSTDOC changes may affect cache busting behavior. Please verify that switching to a compile-time option_env! check achieves the intended effect without impacting build script re-run triggers.
println!("cargo::rerun-if-env-changed=RUSTDOC");
nyurik
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After looking into how our CI works, this needs an actual dependency bump to bust the cache.
Also, the
rerun-if-env-changedcan in this case be replaced withoption_env