Skip to content

Comments

fix(ci): cargo update to evict the cache#1798

Merged
CommanderStorm merged 1 commit intomaplibre:mainfrom
CommanderStorm:ci-fix
Apr 16, 2025
Merged

fix(ci): cargo update to evict the cache#1798
CommanderStorm merged 1 commit intomaplibre:mainfrom
CommanderStorm:ci-fix

Conversation

@CommanderStorm
Copy link
Member

After looking into how our CI works, this needs an actual dependency bump to bust the cache.

Also, the rerun-if-env-changed can in this case be replaced with option_env

Copilot AI review requested due to automatic review settings April 16, 2025 22:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps dependencies to bust the cache and updates the build script to use a compile‐time check for the RUSTDOC environment variable instead of the runtime approach.

  • Removed the outdated cargo directive that triggered re-run of the build script via an environment variable.
  • Replaced runtime environment variable check with a compile-time option_env! call.
Comments suppressed due to low confidence (1)

martin/build.rs:104

  • The removal of the cargo directive that triggers the build re-run when RUSTDOC changes may affect cache busting behavior. Please verify that switching to a compile-time option_env! check achieves the intended effect without impacting build script re-run triggers.
println!("cargo::rerun-if-env-changed=RUSTDOC");

@CommanderStorm CommanderStorm changed the title cargo update to bump the cache fix(ci): cargo update to bump the cache Apr 16, 2025
@CommanderStorm CommanderStorm enabled auto-merge (squash) April 16, 2025 22:23
@CommanderStorm CommanderStorm changed the title fix(ci): cargo update to bump the cache fix(ci): cargo update to evict the cache Apr 16, 2025
@CommanderStorm CommanderStorm merged commit 7cb963f into maplibre:main Apr 16, 2025
20 checks passed
@CommanderStorm CommanderStorm deleted the ci-fix branch July 10, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants