Remove postgis 11-3.0 test and fix gdalbin installation#1785
Merged
CommanderStorm merged 4 commits intomaplibre:mainfrom Apr 12, 2025
Merged
Remove postgis 11-3.0 test and fix gdalbin installation#1785CommanderStorm merged 4 commits intomaplibre:mainfrom
CommanderStorm merged 4 commits intomaplibre:mainfrom
Conversation
Comment on lines
-457
to
-459
| - img_ver: 11-3.0-alpine | ||
| args: postgres | ||
| sslmode: disable |
Member
There was a problem hiding this comment.
I might be missing something, but I don't think we need to drop this.
#1774 only had problems with gdal as far as I can see. 🤔
Collaborator
Author
There was a problem hiding this comment.
Yes.It failed because gdal installation. And Maybe it's time to drop the test as v11 is too old? @nyurik
Member
There was a problem hiding this comment.
yeah, i think v11 and even v12 might be ok to be dropped
CommanderStorm
approved these changes
Apr 12, 2025
| @@ -454,9 +454,6 @@ jobs: | |||
| matrix: | |||
| include: | |||
| # These must match the versions of postgres used in the docker-compose.yml | |||
Member
There was a problem hiding this comment.
Lets split these apart. the CI issue is getting annoying
Suggested change
| # These must match the versions of postgres used in the docker-compose.yml | |
| # These must match the versions of postgres used in the docker-compose.yml | |
| - img_ver: 11-3.0-alpine | |
| args: postgres | |
| sslmode: disable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.