Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload coverage in separate workflow #1769

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Oct 17, 2023

We need to upload the coverage in a separate workflow, becuase it needs access to the codecov secret.

@louwers louwers added the github_actions Pull requests that update GitHub Actions code label Oct 17, 2023
@louwers louwers requested a review from HarelM October 17, 2023 13:20
@louwers louwers enabled auto-merge (squash) October 17, 2023 13:20
Copy link
Collaborator

@ntadej ntadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a secret? I don't need it in any of my repos?

@louwers
Copy link
Collaborator Author

louwers commented Oct 17, 2023

@ntadej Because Codecov gets rate limited by GitHub otherwise. This is causing the workflow to fail periodically.

https://community.codecov.com/t/github-api-forbidden/1295/4

codecov/codecov-action#557

@louwers
Copy link
Collaborator Author

louwers commented Oct 17, 2023

Temporarily disabling code coverage check to merge.

@louwers louwers merged commit 902b8ca into maplibre:main Oct 17, 2023
17 checks passed
@louwers
Copy link
Collaborator Author

louwers commented Oct 17, 2023

Enabled again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants