Skip to content

fix windows mise shell args#210

Merged
sargunv merged 1 commit into
mainfrom
codex/fix-windows-mise-shell-args
Jun 7, 2026
Merged

fix windows mise shell args#210
sargunv merged 1 commit into
mainfrom
codex/fix-windows-mise-shell-args

Conversation

@sargunv

@sargunv sargunv commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

jdx/mise#10148 made a breaking change to windows mise shell parsing, updating our config to align.

windows contributors will likely need to ensure their mise is up to date.

AI assistance

  • Tools: Codex
  • Models: GPT-5
  • Context: Investigated Windows CI failures, identified the mise Windows shell parser change, and applied the focused quoting fix.

@sargunv sargunv marked this pull request as ready for review June 7, 2026 01:35
@sargunv sargunv changed the title [codex] fix windows mise shell args fix windows mise shell args Jun 7, 2026
@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates mise.toml to fix Windows shell argument parsing following a breaking change in mise (jdx/mise#10148) that changed how quotes inside Windows shell args are interpreted.

  • windows_default_file_shell_args and windows_default_inline_shell_args now use "" (doubled double-quote) as the escape sequence for a literal " inside a double-quoted token, replacing the previous \" backslash-escape style that the updated mise parser no longer recognises on Windows.

Confidence Score: 5/5

This is a safe, minimal config change targeting only the Windows shell arg quoting style with no effect on Unix paths.

The two changed lines directly mirror the quoting convention documented in the upstream mise breaking-change PR. The escaping logic is internally consistent: every \" in the old strings becomes "", quote counts balance correctly in both the file and inline variants, and the surrounding TOML single-quote literal means no TOML-level parsing ambiguity is introduced.

No files require special attention; only mise.toml changed and the delta is two lines.

Important Files Changed

Filename Overview
mise.toml Updates Windows shell arg quoting from backslash-escaped quotes (\") to doubled-quote escaping ("") to align with a breaking change in mise's Windows shell parser (jdx/mise#10148).

Reviews (1): Last reviewed commit: "fix windows mise shell args" | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4eef619d-3896-45df-a945-0dd08732f7a1

📥 Commits

Reviewing files that changed from the base of the PR and between 25a4855 and be6f2a7.

📒 Files selected for processing (1)
  • mise.toml

📝 Walkthrough

Summary by CodeRabbit

Chores

  • Updated Windows shell argument configuration for improved path handling and enhanced command execution reliability on Windows systems.

Walkthrough

The PR updates Windows shell argument configurations in mise.toml to correct the escaping syntax for path references. Both windows_default_file_shell_args and windows_default_inline_shell_args are adjusted to use proper mise template variable escaping instead of raw dollar-sign quoting.

Changes

Windows Shell Configuration

Layer / File(s) Summary
Windows Shell Argument Escaping
mise.toml
windows_default_file_shell_args and windows_default_inline_shell_args are updated to use mise template variable style escaping for $MLN_FFI_REPO_ROOT path references when sourcing Windows scripts and executing commands.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix windows mise shell args' is concise and clearly describes the primary change in the PR, which involves updating Windows mise shell argument configurations.
Description check ✅ Passed The PR description includes the required 'Summary' section explaining what changed and why, references the upstream change, and includes the 'AI assistance' section with tool, model, and context details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sargunv sargunv merged commit 1068eaa into main Jun 7, 2026
24 checks passed
@sargunv sargunv deleted the codex/fix-windows-mise-shell-args branch June 7, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant