Skip to content

Make sure coop-gesture overlay always on top#1753

Merged
HarelM merged 1 commit into
maplibre:mainfrom
blyme:cooperativeGestures-z-index
Oct 19, 2022
Merged

Make sure coop-gesture overlay always on top#1753
HarelM merged 1 commit into
maplibre:mainfrom
blyme:cooperativeGestures-z-index

Conversation

@blyme
Copy link
Copy Markdown
Contributor

@blyme blyme commented Oct 19, 2022

Add a high z-index to the cooperativeGesture overlay.
This make sure that, e.g, popups in a map, always is below the overlay.

CooperativeGestures introduced in #1234

Before

image

After

image

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.

@HarelM
Copy link
Copy Markdown
Collaborator

HarelM commented Oct 19, 2022

Yup, thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2022

Bundle size report:

Size Change: +3 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file Before After Change
maplibre-gl.js 196 kB 196 kB 0 B
maplibre-gl.css 9.09 kB 9.09 kB +3 B
ℹ️ View Details No major changes

@HarelM
Copy link
Copy Markdown
Collaborator

HarelM commented Oct 19, 2022

Can you add a chanelog entry please?

@blyme
Copy link
Copy Markdown
Contributor Author

blyme commented Oct 19, 2022

Done @HarelM 🙂

@HarelM HarelM merged commit 55ab86c into maplibre:main Oct 19, 2022
@HarelM
Copy link
Copy Markdown
Collaborator

HarelM commented Oct 19, 2022

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants