This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Merged
Conversation
Contributor
Author
|
Last unsolved problem: /maplibre-gl-js-docs/assets/favicon/site.webmanifest?v=rMBbQAR5BL not found in debug server, but found when statically served. |
Contributor
Author
|
Still some minor but hard to fix bugs left, but none of this is additionally to ones in the main branch. I think this is ready for production. |
Contributor
|
Thanks for working on this. Please remove the hard-coded version reference and use a dynamic one. |
wipfli
reviewed
Jul 29, 2021
Contributor
Author
No, it does not. I ran a script to ensure all files have a hideFeedback attribute. This also resorted the order of attributes unintentionally. I will fix this within an additional commit. After squashing the PR this noise should be removed. |
marcelnormann
changed the title
wipfli
approved these changes
Sep 2, 2021
Contributor
wipfli
left a comment
wipfli
left a comment
There was a problem hiding this comment.
Thanks for the clean-up Marcel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy reverse engineering of uglyfied code