Do not use node package for creating remark config any more -> so we can exclude check for proudct,#61
Conversation
… check for product
|
Looks interesting. And how can we make Also, do we even care about the |
You can't add it. The line
ensures that the product name is not checked.
maplibre-gl-js-docs/.remarkrc.js Line 43 in f47677f
I think you are right. I can't see the product name on the page either. It just bothered me. That's why I searched where to change it. |
|
Great, thanks for the clarification. I think even if this change will not show up in the frontend, it is still worth doing since we can remove |
Because of the
remarkconfiguration we can not use Maplibre asproductname . I stumbled across this in #58. It is not possible to useMaplibre GL JSin https://github.com/maplibre/maplibre-gl-js-docs/pull/58/files#diff-604664e92c63ab379a8bdf863252857482ffd1f642e3cdd4223985ad9ca8a705 asproductname.Thereby we would have the possibility to overwrite this via parameter.
Unfortunately, this ist not possible in our repositiory, if we use the package remark-config-docs for creating the configuration.
Therefore, I removed the package [remark-config-docs] (https://www.npmjs.com/package/@mapbox/remark-config-docs) and added the same configuration statically.
A static implementation is not the best, I know. But this way
Maplibre docsone package more independent.What do you think?