Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix publish ci, update .gitignore #424

Merged
merged 18 commits into from
May 21, 2024
Merged
13 changes: 7 additions & 6 deletions .github/workflows/publish-single.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,14 @@ jobs:
permissions:
id-token: write # This is required for requesting the OIDC
runs-on: ubuntu-latest
if: github.repository_owner == 'maplibre'
steps:
- uses: actions/checkout@v4
# Setup Dart SDK with JWT token
- uses: dart-lang/setup-dart@v1
- uses: subosito/flutter-action@v2
with:
cache: true
- name: Install dependencies
run: dart pub get
# Publishing...
# skip validation due to https://github.com/dart-lang/setup-dart/issues/68
run: flutter pub get
# --force skips the y/N confirmation
- name: Publish to pub.dev
run: dart pub publish --force --skip-validation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revert these changes, release is stuck here.

Copy link
Collaborator Author

@josxha josxha May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run: flutter pub publish --force
8 changes: 4 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Publish maplibre_gl packages to pub.dev
name: Publish packages to pub.dev

on:
push:
Expand All @@ -10,16 +10,16 @@ permissions:

jobs:
publish_maplibre_gl_platform_interface:
uses: ./.github/workflows/publish_single.yml
uses: maplibre/flutter-maplibre-gl/.github/workflows/publish-single.yml@main
josxha marked this conversation as resolved.
Show resolved Hide resolved
with:
working-directory: maplibre_gl_platform_interface
publish_maplibre_gl_web:
needs: [publish_maplibre_gl_platform_interface]
uses: ./.github/workflows/publish_single.yml
uses: maplibre/flutter-maplibre-gl/.github/workflows/publish-single.yml@main
with:
working-directory: maplibre_gl_web
publish_maplibre_gl:
needs: [publish_maplibre_gl_platform_interface, publish_maplibre_gl_web]
uses: ./.github/workflows/publish_single.yml
uses: maplibre/flutter-maplibre-gl/.github/workflows/publish-single.yml@main
with:
working-directory: .
97 changes: 11 additions & 86 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
.buildlog/
.history
.svn/
migrate_working_dir/

# IntelliJ related
*.iml
Expand All @@ -21,103 +22,27 @@
.settings/
.vscode/

# Flutter repo-specific
/bin/cache/
/bin/mingit/
/dev/benchmarks/mega_gallery/
/dev/bots/.recipe_deps
/dev/bots/android_tools/
/dev/docs/doc/
/dev/docs/flutter.docs.zip
/dev/docs/lib/
/dev/docs/pubspec.yaml
/dev/integration_tests/**/xcuserdata
/dev/integration_tests/**/Pods
/packages/flutter/coverage/
version

# packages file containing multi-root paths
.packages.generated

# Flutter/Dart/Pub related
**/doc/api/
**/ios/Flutter/.last_build_id
.dart_tool/
.flutter-plugins
.flutter-plugins-dependencies
.packages
.pub-cache/
.pub/
**/pubspec.lock
build/
flutter_*.png
linked_*.ds
unlinked.ds
unlinked_spec.ds

# Android related
**/android/**/gradle-wrapper.jar
**/android/.gradle
**/android/captures/
**/android/gradlew
**/android/gradlew.bat
**/android/local.properties
**/android/**/GeneratedPluginRegistrant.java
**/android/key.properties
*.jks

# iOS/XCode related
**/ios/**/*.mode1v3
**/ios/**/*.mode2v3
**/ios/**/*.moved-aside
**/ios/**/*.pbxuser
**/ios/**/*.perspectivev3
**/ios/**/*sync/
**/ios/**/.sconsign.dblite
**/ios/**/.tags*
**/ios/**/.vagrant/
**/ios/**/DerivedData/
**/ios/**/Icon?
**/ios/**/Pods/
**/ios/**/.symlinks/
**/ios/**/profile
**/ios/**/xcuserdata
**/ios/.generated/
**/ios/Flutter/App.framework
**/ios/Flutter/Flutter.framework
**/ios/Flutter/Flutter.podspec
**/ios/Flutter/Generated.xcconfig
**/ios/Flutter/app.flx
**/ios/Flutter/app.zip
**/ios/Flutter/flutter_assets/
**/ios/Flutter/flutter_export_environment.sh
**/ios/ServiceDefinitions.json
**/ios/Runner/GeneratedPluginRegistrant.*

# macOS
**/macos/Flutter/GeneratedPluginRegistrant.swift
**/macos/Flutter/Flutter-Debug.xcconfig
**/macos/Flutter/Flutter-Release.xcconfig
**/macos/Flutter/Flutter-Profile.xcconfig
/build/
pubspec.lock

# Coverage
coverage/

# Symbols
# Symbolication related
app.*.symbols

# Exceptions to above rules.
!**/ios/**/default.mode1v3
!**/ios/**/default.mode2v3
!**/ios/**/default.pbxuser
!**/ios/**/default.perspectivev3
!/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages
!/dev/ci/**/Gemfile.lock
google-java-format-1.13.0-all-deps.jar

# Ruby/CocoaPods
Gemfile*
.ruby-version
# Obfuscation related
app.*.map.json

# FVM Version Cache
.fvm/
.fvmrc
# Android Studio will place build artifacts here
/android/app/debug
/android/app/profile
/android/app/release
1 change: 0 additions & 1 deletion example/ios/Flutter/.last_build_id

This file was deleted.

16 changes: 16 additions & 0 deletions example/macos/Flutter/GeneratedPluginRegistrant.swift
kuhnroyal marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//
// Generated file. Do not edit.
//

import FlutterMacOS
import Foundation

import device_info_plus
import location
import path_provider_foundation

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
DeviceInfoPlusMacosPlugin.register(with: registry.registrar(forPlugin: "DeviceInfoPlusMacosPlugin"))
LocationPlugin.register(with: registry.registrar(forPlugin: "LocationPlugin"))
PathProviderPlugin.register(with: registry.registrar(forPlugin: "PathProviderPlugin"))
}