Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete pubspec.lock #314

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

m0nac0
Copy link
Collaborator

@m0nac0 m0nac0 commented Oct 9, 2023

According to the official docs, the pubspec.lock should only be checked into git for application packages (which our example app probably is), but not for plugins: https://dart.dev/tools/pub/package-layout#the-pubspec

@m0nac0 m0nac0 marked this pull request as ready for review October 9, 2023 18:29
@JulianBissekkou
Copy link
Collaborator

Thanks for creating so many PRs lately and cleaning things up :)

@JulianBissekkou JulianBissekkou merged commit 3405cff into maplibre:main Oct 10, 2023
@m0nac0
Copy link
Collaborator Author

m0nac0 commented Oct 10, 2023

Sure, I was in the process of looking into #309 and thinking about an overhaul of the release process to prepare a new release, and these kind of came up in the process anyways :)

@m0nac0 m0nac0 deleted the remove-lockfile branch October 10, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants