Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoMapping: Ignore rules with empty input or output regions #4115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjorn
Copy link
Member

@bjorn bjorn commented Dec 5, 2024

Rules with an empty input region were causing issues, because they don't have a valid bounding rectangle. They are also commonly created by accident. If intended as a rule that always matches, such a rule can be made by placing the special "Ignore" tile in the rule's input.

Rules with empty output region are no longer matched because they would not produce any output anyway.

As a drive-by, AutoMapper no longer derives from QObject, which appears to have only been done to access the tr() function. This is now made available using Q_DECLARE_TR_FUNCTIONS instead.

Closes #3834

Rules with an empty input region were causing issues, because they don't
have a valid bounding rectangle. They are also commonly created by
accident. If intended as a rule that always matches, such a rule can be
made by placing the special "Ignore" tile in the rule's input.

Rules with empty output region are no longer matched because they would
not produce any output anyway.

As a drive-by, AutoMapper no longer derives from QObject, which appears
to have only been done to access the tr() function. This is now made
available using Q_DECLARE_TR_FUNCTIONS instead.

Closes mapeditor#3834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automapping: Rules with empty input don't affect top and left of map
1 participant