Added support for a parallax scroll factor per layer #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it work as expected for layers at an offset or using a scroll factor.
Even though implemented as mostly just a factor on the scrolling speed, the term "parallax" is more familiar and should make this feature easier to discover.
* Centering the view on an object when it is clicked in the Objects view now takes into account the parallax factor of its layer when needed. * The JumpToTile action now takes parallax factor into account, as well as possible layer offset (affects navigation to warning/error locations). * When pasting objects they are correctly placed in the view center or below the mouse, even when pasting into a layer that is offset or which has a parallax factor applied. Also renamed "scroll offset" to "parallax offset".
bjorn
force-pushed
the
wip/scroll-factor
branch
from
40ad457 to
cfe6f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1071
These changes add a per-layer parallax factor (separate for x and y, though usually they'd be the same). Editing operations have been adjusted to work with the parallax effect enabled.