Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terrain previews are hard to understand when unused Mixed labels are present #3204

Closed
eishiya opened this issue Dec 8, 2021 · 0 comments · Fixed by #3901
Closed

Terrain previews are hard to understand when unused Mixed labels are present #3204

eishiya opened this issue Dec 8, 2021 · 0 comments · Fixed by #3901
Labels
usability Generally about making something more intuitive or efficient.

Comments

@eishiya
Copy link
Contributor

eishiya commented Dec 8, 2021 •
edited
Loading

When a Mixed Terrain Set has its type switched to Corner or Edge, the corner labels are rendered as they would for corner-based sets, which looks weird when edge labels are present.

This is an Edge terrain, but it sure doesn't look like one:
image

It's also weird that corners get special treatment in Edge mode.

I think the following changes would help the labels be clearer and make it easier to discern which labels are actually used:

  • in Edge mode, corners should be rendered the same as they are in Mixed mode, without being connected to each other
  • in Corner mode, edges should be rendered without being connected to the opposite edge
  • currently unused labels (i.e. corners in Edge mode, and edges in Corner mode) should be drawn with a lower opacity
@bjorn bjorn added the usability Generally about making something more intuitive or efficient. label Dec 8, 2021
@eishiya eishiya mentioned this issue Feb 3, 2022
Closed
bjorn added a commit to bjorn/tiled-dev that referenced this issue Mar 5, 2024
@bjorn
Terrain tools now ignore irrelevant labels
e3d8c3f 
Changing the type of a Terrain Set does not clear no longer relevant
bits from each tile, in order to allow changing the type back and forth
without destroying this information.

However, this caused the terrain overlays to be confusing and terrain
tools to behave erratically. Now, the irrelevant bits of each tile's
terrain info is masked out where appropriate.

Closes mapeditor#3204
Closes mapeditor#3260
@bjorn bjorn mentioned this issue Mar 5, 2024
Merged
@bjorn bjorn closed this as completed in f46b444 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
usability Generally about making something more intuitive or efficient.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Terrain tools now ignore irrelevant labels bjorn/tiled-dev
2 participants
@bjorn @eishiya