Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Implement Copy for InvalidTilesetError #296

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

aleokdev
Copy link
Contributor

Not sure how PR passed thru CI, I can't compile because of our deny(missing_copy_implementations) lint.

@bjorn
Copy link
Member

bjorn commented Jun 12, 2024

Why did you need the "Trigger CI" commit?

@aleokdev
Copy link
Contributor Author

Why did you need the "Trigger CI" commit?

I accidentally based the branch against current, and changing to next didn't retrigger CI

@bjorn
Copy link
Member

bjorn commented Jun 12, 2024

I accidentally based the branch against current, and changing to next didn't retrigger CI

Ah, alright. I think you should remove the commit before I approve the PR though.

@aleokdev
Copy link
Contributor Author

I was going to squash before merging for consistency anyways, but I'll rebase to remove that commit if you want

Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forgot about squashing after getting used to fast-forward merging on GitLab for a bit...

Anyway, approved then, but don't you want to add a changelog entry? :-)

@aleokdev
Copy link
Contributor Author

Anyway, approved then, but don't you want to add a changelog entry? :-)

Not really, I remembered this time; This hotfix doesn't affect previously released versions so adding a changelog entry for it wouldn't make much sense

@aleokdev aleokdev merged commit a521dd3 into mapeditor:next Jun 13, 2024
3 checks passed
@aleokdev aleokdev deleted the hotfix_impl_copy branch June 13, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants