fix: if passed python option set environment variable #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if passed the --python option node-gyp would always use it, now the only way to force using that value is to set an environment variable pointing to it
Contributor
|
Thanks for trying to fix this. A while back (apologies I don't have the link handy) I fixed this by adjusting the test instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if passed the --python option node-gyp would always use it, now the only way to force
using that value is to set an environment variable pointing to it
This gets a little closer to getting the tests running, locally I'm still seeing some issues in tests failing to compile due to changes in Node that impact the c++ code, unfortunately those fixes are beyond me 😄