-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for carplay to hide waypoints from route line #4606
Merged
chizhavko
merged 3 commits into
main
from
chizhavko/update-delegate-methods-for-carplay
Mar 11, 2024
Merged
Add support for carplay to hide waypoints from route line #4606
chizhavko
merged 3 commits into
main
from
chizhavko/update-delegate-methods-for-carplay
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API compatibility report for MapboxNavigation: 🔴Protocol Requirement Change
|
1 similar comment
API compatibility report for MapboxNavigation: 🔴Protocol Requirement Change
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #4606 +/- ##
==========================================
- Coverage 60.63% 60.54% -0.10%
==========================================
Files 189 189
Lines 21265 21297 +32
==========================================
Hits 12894 12894
- Misses 8371 8403 +32
|
kried
reviewed
Mar 6, 2024
kried
reviewed
Mar 7, 2024
kried
approved these changes
Mar 11, 2024
Sources/MapboxNavigation/CarPlayNavigationViewControllerDelegate.swift
Outdated
Show resolved
Hide resolved
chizhavko
force-pushed
the
chizhavko/update-delegate-methods-for-carplay
branch
from
March 11, 2024 12:19
98903b1
to
c69cacd
Compare
kried
reviewed
Mar 11, 2024
kried
reviewed
Mar 11, 2024
Co-authored-by: Nastassia Makaranka <[email protected]>
Co-authored-by: Nastassia Makaranka <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From this ticket: https://mapbox.atlassian.net/browse/NAVIOS-1619
To hide waypoints on route line. Later they override NavigationMapDelegate. For now this method not used and CarPLayManagerDelegate only support configuration of destination waypoint. In this MR i added ability to hide intermediate waypoints on the route line.