Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for carplay to hide waypoints from route line #4606

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

chizhavko
Copy link
Contributor

@chizhavko chizhavko commented Mar 6, 2024

Description

From this ticket: https://mapbox.atlassian.net/browse/NAVIOS-1619
To hide waypoints on route line. Later they override NavigationMapDelegate. For now this method not used and CarPLayManagerDelegate only support configuration of destination waypoint. In this MR i added ability to hide intermediate waypoints on the route line.

@chizhavko chizhavko requested a review from a team as a code owner March 6, 2024 07:49
@mapbox-github-ci-issues-public-1

API compatibility report for MapboxNavigation: 🔴

Protocol Requirement Change

  • Func CarPlayManagerDelegate.carPlayManager(_:waypointCircleLayerWithIdentifier:sourceIdentifier:) has been added as a protocol requirement
  • Func CarPlayManagerDelegate.carPlayManager(_:waypointSymbolLayerWithIdentifier:sourceIdentifier:) has been added as a protocol requirement
  • Func CarPlayNavigationViewControllerDelegate.carPlayNavigationViewController(_:waypointCircleLayerWithIdentifier:sourceIdentifier:) has been added as a protocol requirement
  • Func CarPlayNavigationViewControllerDelegate.carPlayNavigationViewController(_:waypointSymbolLayerWithIdentifier:sourceIdentifier:) has been added as a protocol requirement

1 similar comment
@mapbox-github-ci-issues-public-1

API compatibility report for MapboxNavigation: 🔴

Protocol Requirement Change

  • Func CarPlayManagerDelegate.carPlayManager(_:waypointCircleLayerWithIdentifier:sourceIdentifier:) has been added as a protocol requirement
  • Func CarPlayManagerDelegate.carPlayManager(_:waypointSymbolLayerWithIdentifier:sourceIdentifier:) has been added as a protocol requirement
  • Func CarPlayNavigationViewControllerDelegate.carPlayNavigationViewController(_:waypointCircleLayerWithIdentifier:sourceIdentifier:) has been added as a protocol requirement
  • Func CarPlayNavigationViewControllerDelegate.carPlayNavigationViewController(_:waypointSymbolLayerWithIdentifier:sourceIdentifier:) has been added as a protocol requirement

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 60.54%. Comparing base (c09a4b8) to head (9b58b55).

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4606      +/-   ##
==========================================
- Coverage   60.63%   60.54%   -0.10%     
==========================================
  Files         189      189              
  Lines       21265    21297      +32     
==========================================
  Hits        12894    12894              
- Misses       8371     8403      +32     
Files Coverage Δ
Sources/MapboxNavigation/CarPlayManager.swift 44.35% <0.00%> (-0.28%) ⬇️
...rces/MapboxNavigation/CarPlayManagerDelegate.swift 3.07% <0.00%> (-0.21%) ⬇️
...tion/CarPlayNavigationViewControllerDelegate.swift 0.00% <0.00%> (ø)
...oxNavigation/CarPlayNavigationViewController.swift 14.34% <0.00%> (-0.16%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
chizhavko and others added 2 commits March 11, 2024 15:33
Co-authored-by: Nastassia Makaranka <[email protected]>
@chizhavko chizhavko merged commit c8859dc into main Mar 11, 2024
21 checks passed
@chizhavko chizhavko deleted the chizhavko/update-delegate-methods-for-carplay branch March 11, 2024 12:54
@kried kried mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants