Skip to content

Commit

Permalink
Fix SystemSpeechSynthesizer related main thread hang on NavigationVie…
Browse files Browse the repository at this point in the history
…wController creation (#4617)

* Don't check if AVSpeechSynthesizer.isSpeaking when unmuting it

* add changelog entry
  • Loading branch information
azarovalex authored Mar 27, 2024
1 parent dc90edc commit 38b45ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
* Removed `NavigationEventsManager.init(activeNavigationDataSource:passiveNavigationDataSource:accessToken:mobileEventsManager:)` in favor of `NavigationEventsManager.init(activeNavigationDataSource:passiveNavigationDataSource:accessToken:)`. ([#4572](https://github.com/mapbox/mapbox-navigation-ios/pull/4572))
* Fixed a rare issue that could lead to memory corruption under specific conditions. This was resolved by replacing the internal image downloader with brand new actor-based implementation. ([#4588](https://github.com/mapbox/mapbox-navigation-ios/pull/4588))
* Fixed the possible situation when the upcoming route leg is rendered above the active route leg. ([#4588](https://github.com/mapbox/mapbox-navigation-ios/pull/4588))
* Fixed a main thread hang on NavigationViewController creation. ([#4617](https://github.com/mapbox/mapbox-navigation-ios/pull/4617))

## v2.17.0

Expand Down
2 changes: 1 addition & 1 deletion Sources/MapboxNavigation/SystemSpeechSynthesizer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ open class SystemSpeechSynthesizer: NSObject, SpeechSynthesizing {
public weak var delegate: SpeechSynthesizingDelegate?
public var muted: Bool = false {
didSet {
if isSpeaking {
if muted, isSpeaking {
interruptSpeaking()
}
}
Expand Down

0 comments on commit 38b45ba

Please sign in to comment.