Skip to content

NN: start and stop nav session #7145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RingerJK merged 2 commits into from
Apr 28, 2023
Merged

NN: start and stop nav session #7145

RingerJK merged 2 commits into from
Apr 28, 2023

Conversation

@RingerJK
Copy link
Contributor

@RingerJK RingerJK commented Apr 28, 2023

Description

NN: start and stop nav session

@RingerJK RingerJK requested a review from averkhaturau April 28, 2023 08:30
@RingerJK RingerJK self-assigned this Apr 28, 2023
@RingerJK RingerJK mentioned this pull request Apr 28, 2023
Closed
@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Changelog

Features

Bug fixes and improvements

  • Fixed an issue where DirectionsRoute#duration ignored charge time after refresh operation. [#7121](https://github.com/mapbox/mapbox-navigation-android/pull/7121)
  • Deprecated MapboxNavigation#setRerouteController method. Using custom rerouting logic is now deprecated. [#7129](https://github.com/mapbox/mapbox-navigation-android/pull/7129)
  • Introduced MapboxNavigation#setRerouteEnabled to disable/enable reroutes instead of using custom reroute controller. By default rerouting is enabled. [#7129](https://github.com/mapbox/mapbox-navigation-android/pull/7129)
  • Improved quality of continuous alternatives, now the mechanism respects routes from current navigation session. [#7137](https://github.com/mapbox/mapbox-navigation-android/pull/7137)
  • Improved EV offline navigation, now it fallbacks to a regular onboard routing. [#7137](https://github.com/mapbox/mapbox-navigation-android/pull/7137)
  • Improved location simulation when DR ends, i.e. when a driver leaves a tunnel. [#7137](https://github.com/mapbox/mapbox-navigation-android/pull/7137)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@RingerJK RingerJK marked this pull request as ready for review April 28, 2023 09:35
dzinad
dzinad approved these changes Apr 28, 2023
View reviewed changes
@RingerJK RingerJK requested a review from averkhaturau April 28, 2023 11:43
@RingerJK RingerJK added the skip changelog Should not be added into version changelog. label Apr 28, 2023
averkhaturau
averkhaturau approved these changes Apr 28, 2023
View reviewed changes
Copy link

@averkhaturau averkhaturau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RingerJK RingerJK merged commit 94d6193 into main Apr 28, 2023
@RingerJK RingerJK deleted the kyv-nn-start-and-stop-nav-session branch April 28, 2023 12:46
@mapbox-github-ci-issues-2 mapbox-github-ci-issues-2 bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzinad dzinad dzinad approved these changes

@VysotskiVadim VysotskiVadim Awaiting requested review from VysotskiVadim

+1 more reviewer

@averkhaturau averkhaturau averkhaturau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RingerJK RingerJK

Labels

skip changelog Should not be added into version changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RingerJK @averkhaturau @dzinad