add INTERNET and ACCESS_NETWORK_STATE permissions #6473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't add these permissions as a library because we ourselves don't do any network requests. Please correct me if I'm wrong @mapbox/navigation-android.
The failing test (
TripServiceTest) is part of libnavigation-core module. This module or any of its dependencies does not have these permissions. It was working before because the permissions were added frommapbox-android-telemetry(removed fromlibnavigationmetricsin PR #6423).I added the permissions only to androidTest Manifest because I don't think we should add them as part of the SDK for the reason described above. Any objections?