Fix Events distanceTraveled not being accumulated
#5191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
bug
Guardiola31337
force-pushed
the
pg-events-wrong-distance-traveled
branch
2 times, most recently
from
cc8214b to
78adb88
Compare
Closed
Guardiola31337
force-pushed
the
pg-events-wrong-distance-traveled
branch
from
78adb88 to
a2df739
Compare
Contributor
Author
|
Capturing from @Pavel-4
This is ready for review 🚀 |
LukasPaczos
approved these changes
Dec 9, 2021
LukasPaczos
left a comment
LukasPaczos
left a comment
There was a problem hiding this comment.
LGTM, a couple of nits to address separately if we can.
| assertTrue(events[1] is NavigationDepartEvent) | ||
| assertTrue(events[2] is NavigationRerouteEvent) | ||
| assertTrue(events[3] is NavigationRerouteEvent) | ||
| assertEquals(30, (events[3] as NavigationRerouteEvent).distanceCompleted) |
There was a problem hiding this comment.
Suggested change
| assertEquals(30, (events[3] as NavigationRerouteEvent).distanceCompleted) | |
| assertEquals(ROUTE_PROGRESS_DISTANCE_TRAVELED * 2, (events[3] as NavigationRerouteEvent).distanceCompleted) |
Comment on lines
759
to
762
| val dynamicValues = sessionMetadata?.dynamicValues | ||
| val currentDistanceTraveled = dynamicValues?.currentDistanceTraveled ?: 0 | ||
| val accumulatedDistanceTraveled = dynamicValues?.accumulatedDistanceTraveled ?: 0 | ||
| val distanceCompleted = currentDistanceTraveled + accumulatedDistanceTraveled |
There was a problem hiding this comment.
This is repeated in multiple places, maybe worth an extension?
| updateRoute(anotherRoute, RoutesExtra.ROUTES_UPDATE_REASON_REROUTE) | ||
| locationsCollector.flushBuffers() | ||
| every { routeProgress.currentState } returns OFF_ROUTE | ||
| updateRouteProgress(1) |
There was a problem hiding this comment.
Suggested change
| updateRouteProgress(1) | |
| updateRouteProgress(count = 1) |
Guardiola31337
force-pushed
the
pg-events-wrong-distance-traveled
branch
from
a2df739 to
2ec578e
Compare
Guardiola31337
pushed a commit
that referenced
this pull request
Dec 9, 2021
Guardiola31337
pushed a commit
that referenced
this pull request
Dec 9, 2021
Guardiola31337
pushed a commit
that referenced
this pull request
Dec 9, 2021
Guardiola31337
pushed a commit
that referenced
this pull request
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
distanceTravelednot being accumulatedRegression from #3540 https://github.com/mapbox/mapbox-navigation-android/pull/3540/files#diff-c5b716f21ea8e298bbe4b1f715880f4d4e8f1a8d4d42fbeb1008f286f0587c55L632-L634
Opening this as a
Draftto get initial feedback while doing further testing downstream.cc @baddleydone @truburt @Pavel-4 @bamx23